New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: the EVMClient's IsSendOutTxProcessed method contains many duplicate logic and it's also too long (250 lines) to maintain #1534

Closed

Tracked by

ws4charlie opened this issue Jan 8, 2024 · 0 comments · Fixed by #1989

Assignees

Labels

code-quality zetaclient

Contributor

ws4charlie commented Jan 8, 2024 •

edited

Loading

Considering consolidating the func. e.g. take out the duplicate logic to create sub function.
Organize the the code to make it clear and easy for unit tests and maintenance.

ws4charlie self-assigned this

lumtis added zetaclient code-quality labels

lumtis mentioned this issue

ZetaClient Code Structure Revamp #1611

Closed

ws4charlie mentioned this issue

refactor: simply the IsSendOutTxProcessed func #1989

Merged

10 tasks

lumtis closed this as completed in #1989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment