coderabbit feedback

gartnera · gartnera · commit d5d0c221cd90 · 2024-12-19T08:26:09.000-08:00
diff --git a/proto/zetachain/zetacore/observer/tx.proto b/proto/zetachain/zetacore/observer/tx.proto
@@ -2,7 +2,6 @@ syntax = "proto3";
 package zetachain.zetacore.observer;
 
 import "gogoproto/gogo.proto";
-import "google/protobuf/field_mask.proto";
 import "zetachain/zetacore/observer/blame.proto";
 import "zetachain/zetacore/observer/crosschain_flags.proto";
 import "zetachain/zetacore/observer/observer.proto";
diff --git a/x/observer/types/operational.go b/x/observer/types/operational.go
@@ -17,7 +17,7 @@ func (f *OperationalFlags) Validate() error {
 	if f.SignerBlockTimeOffset != nil {
 		signerBlockTimeOffset := *f.SignerBlockTimeOffset
 		if signerBlockTimeOffset < 0 {
-			return ErrOperationalFlagsRestartHeightNegative
+			return ErrOperationalFlagsSignerBlockTimeOffsetNegative
 		}
 		if signerBlockTimeOffset > signerBlockTimeOffsetLimit {
 			return cosmoserrors.Wrapf(ErrOperationalFlagsSignerBlockTimeOffsetLimit, "(%s)", signerBlockTimeOffset)
diff --git a/x/observer/types/operational_test.go b/x/observer/types/operational_test.go
@@ -39,7 +39,7 @@ func TestOperationalFlags_Validate(t *testing.T) {
 			of: types.OperationalFlags{
 				SignerBlockTimeOffset: ptr.Ptr(-time.Second),
 			},
-			errContains: types.ErrOperationalFlagsRestartHeightNegative.Error(),
+			errContains: types.ErrOperationalFlagsSignerBlockTimeOffsetNegative.Error(),
 		},
 		{
 			name: "signer offset limit exceeded",
diff --git a/x/observer/types/tx.pb.go b/x/observer/types/tx.pb.go

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ func (f *OperationalFlags) Validate() error {`
`17`	`17`	`if f.SignerBlockTimeOffset != nil {`
`18`	`18`	`signerBlockTimeOffset := *f.SignerBlockTimeOffset`
`19`	`19`	`if signerBlockTimeOffset < 0 {`
`20`		`- return ErrOperationalFlagsRestartHeightNegative`
	`20`	`+ return ErrOperationalFlagsSignerBlockTimeOffsetNegative`
`21`	`21`	`}`
`22`	`22`	`if signerBlockTimeOffset > signerBlockTimeOffsetLimit {`
`23`	`23`	`return cosmoserrors.Wrapf(ErrOperationalFlagsSignerBlockTimeOffsetLimit, "(%s)", signerBlockTimeOffset)`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ func TestOperationalFlags_Validate(t *testing.T) {`
`39`	`39`	`of: types.OperationalFlags{`
`40`	`40`	`SignerBlockTimeOffset: ptr.Ptr(-time.Second),`
`41`	`41`	`},`
`42`		`- errContains: types.ErrOperationalFlagsRestartHeightNegative.Error(),`
	`42`	`+ errContains: types.ErrOperationalFlagsSignerBlockTimeOffsetNegative.Error(),`
`43`	`43`	`},`
`44`	`44`	`{`
`45`	`45`	`name: "signer offset limit exceeded",`