rpmlint: W: shared-lib-calls-exit /usr/lib64/libvalidator.so.0.9.0 exit@GLIBC_2.2.5

[mgeisler]

When building RPM packages, I see a warning from rpmlint:

W: shared-lib-calls-exit /usr/lib64/libvalidator.so.0.9.0 exit@GLIBC_2.2.5

This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation.

Can someone tell me if this warning is a false positive or if we should fix the calls to exit and _exit?

[bortoq]

i don't see warning when building my sources (not sure about ron's sources). and yes, the code contains "exit"s

[pkit]

These are the functionas that call exit() or _exit()

NaClExit (this one is false positive, as it is not called ever, although it's strange why it's even linked into libvalidator then)

NCDecoderStateSetErrorReporter
NaClValidatorStateSetErrorReporter
NaClInstIterFatal
NaClFatal

All of these can be fixed either by doing something meaningful, or by changing all exists into asserts.

[mgeisler]

Sorry, I should probably have been more explicit about where the rpmlint output is. It's on the openSUSE Build Service where I'm currently testing building RPMs on some random distributions: https://build.opensuse.org/package/show/home:mgeisler/zvm-validator

Click the "Rpmlint Results" tab to see them.