Skip to content

Commit fbd7c4f

Browse files
authored
Merge pull request #260 from zeppelin/remove-deprecated-component
Remove deprecated `<ClickOutside>` component
2 parents dec5e9a + 904e5ef commit fbd7c4f

File tree

5 files changed

+4
-291
lines changed

5 files changed

+4
-291
lines changed

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# ember-click-outside [![Build Status](https://travis-ci.org/zeppelin/ember-click-outside.svg)](https://travis-ci.org/zeppelin/ember-click-outside) [![Ember Observer Score](http://emberobserver.com/badges/ember-click-outside.svg)](http://emberobserver.com/addons/ember-click-outside)
22

3-
A set of tools for detecting click events fired outside an element.
3+
A handy modifier for detecting click events fired outside an element.
44

55
![click outside logo](click-outside-logo.png)
66

@@ -47,6 +47,6 @@ You can listen for events other than `click` by using the `eventType` attribute:
4747

4848
## Behavior
4949

50-
For every click in the document, `ember-click-outside` will check if the click target is outside of its component, and trigger the provided action/callback if so.
50+
For every click in the document, `ember-click-outside` will check if the click target is outside of its element, and trigger the provided action/callback if so.
5151

52-
If the click target cannot be found in the document (probably because it has been deleted before `ember-click-outside` detected the click), no action/callback is triggered, since we cannot check if it is inside or outside of the component.
52+
If the click target cannot be found in the document (probably because it has been deleted before `ember-click-outside` detected the click), no action/callback is triggered, since we cannot check if it is inside or outside of the element.

addon/component.js

-112
This file was deleted.

app/components/click-outside.js

-1
This file was deleted.

tests/dummy/app/templates/application.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{{page-title 'Ember Click Outside Sample'}}
22
<div class='wrapper'>
33
<div {{on-click-outside this.alert}} class='card'>
4-
<h1>Demo click outside component</h1>
4+
<h1>Demo click outside element</h1>
55
<p>
66
Action will only fire when clicking outside it. See the readme for details
77
on how to achieve this &amp; other configuration options.

tests/integration/components/click-outside-test.js

-174
This file was deleted.

0 commit comments

Comments
 (0)