Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTP - incorrect clock offset calculation #76718

Closed
awojasinski opened this issue Aug 6, 2024 · 1 comment · Fixed by #76714
Closed

PTP - incorrect clock offset calculation #76718

awojasinski opened this issue Aug 6, 2024 · 1 comment · Fixed by #76714
Assignees
@awojasinski
Labels
area: PTP IEEE 1588 PTP Protocol bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Milestone
v3.7.1

Comments

@awojasinski
Copy link
Collaborator

Describe the bug
Routine computing PTP clock offset has a wrong sign. Additionally overflow and underflow is not taken into account.

To Reproduce
Compile PTP sample with debug logging enabled and observe PTP clock value

Expected behavior
PTP clock shouldn't jitter

Impact
PTP Clock offset is incorrectly computed
@awojasinski awojasinski added bug The issue is a bug, or the PR is fixing a bug area: PTP IEEE 1588 PTP Protocol labels Aug 6, 2024
@awojasinski awojasinski self-assigned this Aug 6, 2024
@awojasinski awojasinski mentioned this issue Aug 6, 2024
Merged
@awojasinski
Copy link
Collaborator Author

Fixed in #75611 and waiting to backport to 3.7

@awojasinski awojasinski linked a pull request Aug 6, 2024 that will close this issue
[Backport v3.7-branch] net: ptp: Misc clock sync bugs #76714
Merged
@mmahadevan108 mmahadevan108 added the priority: low Low impact/importance bug label Aug 6, 2024
@mmahadevan108 mmahadevan108 added this to the v3.7.1 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awojasinski awojasinski

Labels
area: PTP IEEE 1588 PTP Protocol bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
v3.7.1
Development

Successfully merging a pull request may close this issue.

[Backport v3.7-branch] net: ptp: Misc clock sync bugs zephyrproject-rtos/zephyr
2 participants
@mmahadevan108 @awojasinski