Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFIG_BT_CTLR_OPTIMIZE_FOR_SPEED not selected by default in zephyr 3.7 #76427

Closed
marcowidmer opened this issue Jul 29, 2024 · 3 comments · Fixed by #74916
Closed

CONFIG_BT_CTLR_OPTIMIZE_FOR_SPEED not selected by default in zephyr 3.7 #76427

marcowidmer opened this issue Jul 29, 2024 · 3 comments · Fixed by #74916
Assignees
Labels
Enhancement Changes/Updates/Additions to existing features

Comments

@marcowidmer
Copy link
Collaborator

Describe the bug
Building a bluetooth application for the NRF52 in zephyr 3.6 automatically selected CONFIG_BT_CTLR_OPTIMIZE_FOR_SPEED=y. However, in zephyr 3.7, this default is not selected anymore.

To Reproduce
Run the following command in zephyr 3.6 and zephyr 3.7:

west build samples/bluetooth/peripheral -p -b nrf52840dongle_nrf52840
grep CONFIG_BT_CTLR_OPTIMIZE_FOR_SPEED build/zephyr/.config

Expected behavior
CONFIG_BT_CTLR_OPTIMIZE_FOR_SPEED should be selected in zephyr 3.7, but it is not.

Impact
Bluetooth applications may run slower.

Logs and console output

Environment (please complete the following information):

Additional context
It looks like the reason is that the kconfig choice default introduced in #70251 does not apply because it is inside a kconfig menu which is hidden through a visible if. Enabling the menu fixes the issue:

west build samples/bluetooth/peripheral -p -b nrf52840dongle_nrf52840 -- -DCONFIG_BT_CTLR_ADVANCED_FEATURES=y
@marcowidmer marcowidmer added the bug The issue is a bug, or the PR is fixing a bug label Jul 29, 2024
@marcowidmer
Copy link
Collaborator Author

@cvinayak

@jhedberg jhedberg added priority: low Low impact/importance bug Enhancement Changes/Updates/Additions to existing features and removed bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels Jul 30, 2024
@cvinayak
Copy link
Contributor

cvinayak commented Jul 30, 2024

Will be fixed by 5736518

@marcowidmer
Copy link
Collaborator Author

Thanks, I wasn't aware of the fix. Looks like it will be merged in #74916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants