Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth subsystem uses acl_in_pool even for controllers not supporting flow control #5207

Closed
vakulgarg opened this issue Nov 30, 2017 · 2 comments
Assignees

Comments

@vakulgarg
Copy link
Collaborator

If zephyr compiled with CONFIG_BT_HCI_ACL_FLOW_CONTROL=y is used with a controller which does not support hci acl flow control, it should not use acl_in_pool. The function bt_buf_get_rx() misses checking the flow control capability of controller and allocates from acl_in_pool for all types which are other than BT_BUF_EVT.

@jhedberg
Copy link
Member

See my comment in the pull request. I'm failing to understand how the current behavior is "bad". Btw, the general assumption is that an application writer fine-tunes the configuration for the hardware that is being targeted, so in this case you simply wouldn't enable CONFIG_BT_HCI_ACL_FLOW_CONTROL since you know your hardware doesn't support it. Don't we also have board-specific defaults which could set this to "n" for your board?

@vakulgarg
Copy link
Collaborator Author

I now understand that this is a non issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants