Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ieee802154_settings.c is duplicated in the codebase #4189

Closed
pfalcon opened this issue Oct 5, 2017 · 4 comments
Closed

ieee802154_settings.c is duplicated in the codebase #4189

pfalcon opened this issue Oct 5, 2017 · 4 comments
Assignees
@jukkar @tbursztyka
Labels
area: Networking priority: high High impact/importance bug

Comments

@pfalcon
Copy link
Contributor

pfalcon commented Oct 5, 2017

It's now at:

  • samples/net/common/
  • subsys/net/lib/app/

I hope everyone agrees that's not an OK situation, as the next step for them to diverge, so I'm marking this as prio:high.
@pfalcon pfalcon added area: Networking priority: high High impact/importance bug labels Oct 5, 2017
@tbursztyka
Copy link
Collaborator

That's already taken care of actually. I am just about to send patches for cleaning up this.

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 5, 2017

Cool!

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 5, 2017

Addressed by #4191.

@pfalcon pfalcon closed this as completed Oct 5, 2017
@nashif
Copy link
Member

nashif commented Oct 5, 2017

why are you closing issues before the PR is even merged? That is something that needs to be closed when the PR is merged using the "Fixes #XXXX" handler.

@tbursztyka tbursztyka mentioned this issue Oct 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

@tbursztyka tbursztyka

Labels
area: Networking priority: high High impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nashif @pfalcon @jukkar @tbursztyka