Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shields: mikroe_eth_click config should be made conditional #25501

Closed
erwango opened this issue May 20, 2020 · 1 comment · Fixed by #25512
Closed

shields: mikroe_eth_click config should be made conditional #25501

erwango opened this issue May 20, 2020 · 1 comment · Fixed by #25512
Assignees
Labels
area: Shields Shields (add-on boards) bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@erwango
Copy link
Member

erwango commented May 20, 2020

Describe the bug
mikroe_eth_click provides a static configuration.
This kind of configuration used to create portability issues in application (cf #20934)
It should be reworked to be conditional (.defconfig), as done in other shields

Something like (pseudo code):

îf SHIELD_MIKROE_ETH_CLICK

if NET
CONFIG_SPI=y
CONFIG_NET_L2_ETHERNET=y

# ENC28J60 Ethernet Device
CONFIG_ETH_ENC28J60=y
CONFIG_ETH_ENC28J60_0=y

endif
endif
@erwango erwango added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug priority: low Low impact/importance bug area: Shields Shields (add-on boards) and removed priority: medium Medium impact/importance bug labels May 20, 2020
@erwango
Copy link
Member Author

erwango commented May 20, 2020

@agansari sorry for late feedback, but I didn't think this would go in 2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Shields Shields (add-on boards) bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants