Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zephir stubs - missing "use" statements #1778

Closed
niden opened this issue Dec 11, 2018 · 1 comment
Closed

zephir stubs - missing "use" statements #1778

niden opened this issue Dec 11, 2018 · 1 comment
Assignees
Labels

Comments

@niden
Copy link
Contributor

niden commented Dec 11, 2018

The stubs generated using zephir stubs are missing the use statements at the top of the file.

This might not be a problem since for most of the stubs we have the fully qualified namespace for certain elements i.e.

    /**
     * Sets the dependency injector
     *
     * @param \Phalcon\DiInterface $container
     */
    public function setDI(\Phalcon\DiInterface $container) {}

However it seems return variables are not properly parsed

    /**
     * Returns the internal dependency injector
     *
     * @return \Phalcon\DiInterface
     */
    public function getDI(): DiInterface {}

The same happens with variables

    /**
     * @var <UrlInterface>
     */
    private $url;

I think either we need to add the use statements at the top of the file or parse variables as well as return values with the full namespaces.

@sergeyklay
Copy link
Contributor

Fixed in development branch. Thank you for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants