Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Allow paragonie/random_compat 9.99.99 #38

Closed
wants to merge 5 commits into from
Closed

Allow paragonie/random_compat 9.99.99 #38

wants to merge 5 commits into from

Conversation

snapshotpl
Copy link
Contributor

No description provided.

michalbundyra
michalbundyra reviewed Aug 8, 2018
View reviewed changes
.travis.yml Outdated
@@ -58,7 +58,7 @@ before_install:
- if [[ $TEST_COVERAGE != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi

install:
- travis_retry composer install $COMPOSER_ARGS --ignore-platform-reqs
- travis_retry composer install $COMPOSER_ARGS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this and add paragonie/random_compat into LEGACY_DEPS on PHP 5.6 locked

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webimpress 👍

Witold Wasiczko added 2 commits August 8, 2018 10:42
@snapshotpl
Copy link
Contributor Author

@webimpress looks like travis issue. Can you restart this build?

@michalbundyra
Copy link
Member

@snapshotpl

looks like travis issue. Can you restart this build?

I can't, sorry. You have right - travis issue.

It is fine for me now 👍

michalbundyra
michalbundyra approved these changes Aug 8, 2018
View reviewed changes
Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@michalbundyra michalbundyra mentioned this pull request Dec 4, 2018
Closed
@michalbundyra
Copy link
Member

@weierophinney @Ocramius can we have it merged and released, please?

@weierophinney
Copy link
Member

Can somebody explain to me what the 9.99.99 version is, exactly, and why this is required? I'd like to know for the changelog...

@michalbundyra
Copy link
Member

@weierophinney

Can somebody explain to me what the 9.99.99 version is, exactly, and why this is required? I'd like to know for the changelog...

I think here we have answer:
paragonie/random_compat@7dd806d

And maybe also worth to check this:
paragonie/random_compat@v2.0.17...v9.99.99

weierophinney added a commit that referenced this pull request Dec 4, 2018
@weierophinney
Prepares 3.2.0 CHANGELOG
1626fad 
- Removes empty stub for 3.1.2.
- Remove errant diff marks.
- Adds entry for #38.
- Adds entry for #40.
- Sets date for 3.2.0.
@weierophinney
Copy link
Member

Cherry-picked to develop for release with 3.2.0.

@weierophinney weierophinney mentioned this pull request Dec 4, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michalbundyra michalbundyra michalbundyra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snapshotpl @michalbundyra @weierophinney