Custom AMP Validator Variable Name Collision Fix #10371

msnider · 2020-01-31T20:29:19Z

ISSUE: Regarding issue #9176 and the solution #9191, it appears there is a collision on the variable curRenderOpts.ampValidator with another use expecting a function and not a string causing the error "Error occurred prerendering page "/" https://err.sh/zeit/next.js/prerender-error: TypeError: renderOpts.ampValidator is not a function".

SOLUTION: Rename the variable to curRenderOpts.ampValidatorPath

ijjk · 2020-01-31T20:35:57Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
buildDuration	13.7s	13.6s	-124ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +16 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d6ae.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.9 kB	69.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
main-HASH.module.js gzip	4.11 kB	4.11 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
buildDuration	14.3s	14.5s	⚠️ +215ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +16 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d6ae.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.9 kB	69.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
main-HASH.module.js gzip	4.11 kB	4.11 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_error.js gzip	46.6 kB	46.6 kB	✓
404.html gzip	1.42 kB	1.42 kB	✓
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	46.8 kB	46.8 kB	✓
link.js gzip	72.4 kB	72.4 kB	✓
routerDirect.js gzip	70.4 kB	70.4 kB	✓
withRouter.js gzip	70.5 kB	70.5 kB	✓
Overall change	309 kB	309 kB	✓

Commit: ccaa0d0

timneutkens · 2020-02-01T14:07:18Z

@ijjk can you review

…lidator_path

ijjk

Hi, good catch. I went ahead and added a failing test case for this to make sure we don't regress on it. Thanks for the PR!

ijjk · 2020-02-02T17:47:11Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
buildDuration	10.8s	10.6s	-169ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +16 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d6ae.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.9 kB	69.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
main-HASH.module.js gzip	4.11 kB	4.11 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
buildDuration	10.8s	10.5s	-270ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +16 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d6ae.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.9 kB	69.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
main-HASH.module.js gzip	4.11 kB	4.11 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	msnider/next.js fix_custom_amp_validator_path	Change
_error.js gzip	46.7 kB	46.7 kB	✓
404.html gzip	1.43 kB	1.43 kB	✓
hooks.html gzip	1.06 kB	1.06 kB	✓
index.js gzip	46.8 kB	46.8 kB	✓
link.js gzip	72.3 kB	72.3 kB	✓
routerDirect.js gzip	70.6 kB	70.6 kB	✓
withRouter.js gzip	70.4 kB	70.4 kB	✓
Overall change	309 kB	309 kB	✓

Commit: 42b151b

* Changing variable name internally * Add tests for custom AMP validator Co-authored-by: JJ Kasper <[email protected]>

Changing variable name internally

ccaa0d0

msnider requested review from ijjk, lfades, Timer and timneutkens as code owners January 31, 2020 20:29

ijjk added 2 commits February 2, 2020 11:25

Merge remote-tracking branch 'upstream/canary' into fix_custom_amp_va…

08553d7

…lidator_path

Add tests for custom AMP validator

42b151b

ijjk approved these changes Feb 2, 2020

View reviewed changes

ijjk merged commit d715c13 into vercel:canary Feb 2, 2020

chibicode pushed a commit to chibicode/next.js that referenced this pull request Feb 11, 2020

Custom AMP Validator Variable Name Collision Fix (vercel#10371)

7700617

* Changing variable name internally * Add tests for custom AMP validator Co-authored-by: JJ Kasper <[email protected]>

This was referenced Mar 13, 2020

[Snyk] Upgrade next from 9.2.1 to 9.2.2 pixeldrew/hero-masq#10

Closed

[Snyk] Upgrade @next/mdx from 9.0.5 to 9.2.2 shahinalzahrani/docs#1

Open

This was referenced Mar 22, 2020

[Snyk] Upgrade next from 9.1.5 to 9.2.2 evantahler/next-static-hosting#3

Merged

[Snyk] Upgrade next from 9.2.1 to 9.2.2 grouparoo/next-plugins-example#3

Merged

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom AMP Validator Variable Name Collision Fix #10371

Custom AMP Validator Variable Name Collision Fix #10371

msnider commented Jan 31, 2020

ijjk commented Jan 31, 2020

timneutkens commented Feb 1, 2020

ijjk left a comment

ijjk commented Feb 2, 2020

Custom AMP Validator Variable Name Collision Fix #10371

Custom AMP Validator Variable Name Collision Fix #10371

Conversation

msnider commented Jan 31, 2020

ijjk commented Jan 31, 2020

Stats from current PR

timneutkens commented Feb 1, 2020

ijjk left a comment

Choose a reason for hiding this comment

ijjk commented Feb 2, 2020

Stats from current PR