-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[example with-typescript-graphql] Fix type error #10269
Merged
lfades
merged 2 commits into
vercel:canary
from
piglovesyou:update-example-with-typescript-graphql
Jan 26, 2020
Merged
[example with-typescript-graphql] Fix type error #10269
lfades
merged 2 commits into
vercel:canary
from
piglovesyou:update-example-with-typescript-graphql
Jan 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piglovesyou
commented
Jan 26, 2020
@@ -1,11 +1,11 @@ | |||
# GraphQL and TypeScript Example | |||
# TypeScript and GraphQL Example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's "with-typescript-graphql", I thought the title should be like this.
Stats from current PRDefault Server ModeGeneral
Legacy Client Bundles (polyfills)
Client Build Manifests
Rendered Page Sizes
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Bundles (main, webpack, commons)
Serverless ModeGeneral
Legacy Client Bundles (polyfills)
Client Build Manifests
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Bundles (main, webpack, commons)
Serverless bundles
Commit: ad4a65f |
lfades
approved these changes
Jan 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piglovesyou Thank you 💯
This was referenced Mar 13, 2020
This was referenced Mar 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users download the example with-typescript-graphql, they'll see the following error:
It lacks typing. Let me please add it.