Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set home dir to test env in gh-r tests #582

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

vladdoster
Copy link
Member

@vladdoster vladdoster commented Sep 23, 2023

Description

Handles programs that create a config dir on first invocation and cluttered users $HOME dir.

Screenshot 2023-09-23 at 12 24 47 AM

Motivation and Context

Annoyed

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

Handles programs that create a config dir on first invocation and
cluttered users $HOME dir.

Signed-off-by: Vladislav Doster <[email protected]>
@alichtman
Copy link
Member

alichtman commented Sep 23, 2023

How does this work when the programs go to access $HOME/their_config?

The way I typically fix this issue is by adding XDG support to the program itself.

(Cheers to working on this though. I hate when programs dump things in $HOME.)

@pschmitt
Copy link
Member

This is just for CI testing @alichtman

@vladdoster
Copy link
Member Author

@pschmitt,

It also applies when running gh-r.zunit tests locally.

@vladdoster vladdoster merged commit 9b33288 into main Sep 29, 2023
@vladdoster vladdoster deleted the fix/ghr-test-homr-dir-clutter branch September 29, 2023 07:12
github-actions bot pushed a commit that referenced this pull request Nov 20, 2023
## [3.12.1](v3.12.0...v3.12.1) (2023-11-20)

### Bug Fixes

* container zshelldoc install ([#591](#591)) ([8170753](8170753))
* from'gh-r' skips compile by default ([#590](#590)) ([1f52eee](1f52eee))
* respect delete flags after positional arguments ([#587](#587)) ([e18f9a7](e18f9a7))
* set home dir to test env in gh-r tests ([#582](#582)) ([9b33288](9b33288))
* use $MACHTYPE instead of arch command ([#588](#588)) ([bcf70e8](bcf70e8))
Copy link

🎉 This PR is included in version 3.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@zdharma-continuum zdharma-continuum locked as resolved and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants