From edcec4e6964c2b50f9f9e452f54b36ab86a6b067 Mon Sep 17 00:00:00 2001 From: Simon Franzen Date: Sat, 12 Sep 2020 11:37:53 +0200 Subject: [PATCH] better graphql error handling --- app/controllers/graphql_controller.rb | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/app/controllers/graphql_controller.rb b/app/controllers/graphql_controller.rb index 9461c72..0003f16 100644 --- a/app/controllers/graphql_controller.rb +++ b/app/controllers/graphql_controller.rb @@ -18,9 +18,7 @@ def execute ) render json: result rescue StandardError => e - raise e unless Rails.env.development? - - handle_error_in_development e + handle_error e end private @@ -47,15 +45,14 @@ def ensure_hash(ambiguous_param) end end - def handle_error_in_development(err) + def handle_error(err) logger.error err.message logger.error err.backtrace.join("\n") render json: { - error: { - message: err.message, - backtrace: err.backtrace - }, + errors: [ + { message: err.message } + ], data: {} }, status: 500 end