Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop/replace array_decode_utf8 from benchmark_vlen.ipynb #319

Closed
jakirkham opened this issue May 6, 2022 · 4 comments · Fixed by #321
Closed

Drop/replace array_decode_utf8 from benchmark_vlen.ipynb #319

jakirkham opened this issue May 6, 2022 · 4 comments · Fixed by #321

Comments

@jakirkham
Copy link
Member

jakirkham commented May 6, 2022

In PR ( dask/fastparquet#580 ) included in fastparquet release 0.6.0, array_decode_utf8 was dropped from fastparquet.speedups. We should either drop or replace this benchmark from notebook/benchmark_vlen.ipynb.

For context this notebook was originally added in PR ( #56 ).

@jakirkham
Copy link
Member Author

cc @martindurant (in case you have any thoughts here; no worries if not 🙂)

@jakirkham jakirkham mentioned this issue May 6, 2022
7 tasks
@martindurant
Copy link
Member

I had no idea that this existed!

@jakirkham
Copy link
Member Author

The function or the benchmark? In either case think it was totally reasonable to drop that code from fastparquet (it looked kind of like an internal function). Just didn't know if there was something else we should be using here or if we should just drop it.

@martindurant
Copy link
Member

The encode part was rolled into pack_byte_array, so note reachable from outside, definitely an internal thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants