-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop/replace array_decode_utf8
from benchmark_vlen.ipynb
#319
Comments
cc @martindurant (in case you have any thoughts here; no worries if not 🙂) |
I had no idea that this existed! |
The function or the benchmark? In either case think it was totally reasonable to drop that code from |
The encode part was rolled into pack_byte_array, so note reachable from outside, definitely an internal thing. |
In PR ( dask/fastparquet#580 ) included in
fastparquet
release0.6.0
,array_decode_utf8
was dropped fromfastparquet.speedups
. We should either drop or replace this benchmark fromnotebook/benchmark_vlen.ipynb
.For context this notebook was originally added in PR ( #56 ).
The text was updated successfully, but these errors were encountered: