Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zarf package pull does not respect --key flag #3346

Closed
AustinAbro321 opened this issue Dec 18, 2024 · 0 comments · Fixed by #3347
Closed

zarf package pull does not respect --key flag #3346

AustinAbro321 opened this issue Dec 18, 2024 · 0 comments · Fixed by #3347
Labels
enhancement ✨ New feature or request
Milestone

Comments

@AustinAbro321
Copy link
Contributor

AustinAbro321 commented Dec 18, 2024

Description

zarf package pull does not respect the --key flag. If a package is signed and an incorrect key is given or no key is given the package will still pull.

We could solve this either by removing the key flag or respecting it. The argument for removing the --key flag is that it's already required for signed packages for other commands such as zarf package deploy and zarf package inspect. However a user could still run zarf tools archiver decompress without using the flag. Additionally, if someone's doing a pull (with Internet) before they sneakernet a package into an air gap to do deploy it would be nice to give them a signature validation error early while they still have Internet access

Steps to reproduce

  1. Publish a zarf package with zarf package publish zarf-package-helm-charts-amd64-0.0.1.tar.zst oci://ghcr.io/austinabro321 --signing-key=cosign.key
  2. Pull down the signed package with zarf package pull oci://ghcr.io/austinabro321/local-sign/helm-charts:0.0.1 or zarf package pull oci://ghcr.io/austinabro321/helm-charts:0.0.1 --key=wrong-key.pub

Expected result

The package pull fails if no key is given or the wrong public key is given

Actual Result

The package pull succeeds without warning

@AustinAbro321 AustinAbro321 changed the title Zarf package pull does not respect --key flag zarf package pull does not respect --key flag Dec 18, 2024
@AustinAbro321 AustinAbro321 added bug 🐞 Something isn't working and removed possible-bug 🐛 labels Dec 18, 2024
@AustinAbro321 AustinAbro321 added enhancement ✨ New feature or request and removed bug 🐞 Something isn't working labels Dec 19, 2024
@AustinAbro321 AustinAbro321 added this to the v0.46.0 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant