Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace image pull and push library from ORAS to crane #3559

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Mar 7, 2025

Description

This replaces the Crane library uses for image pulls and pushes with ORAS. This does not change zarf tools crane operations.

Proposal - ZEP-0019: Refactor Image operations #20

This changes the default value to --oci-concurrency from three to six. Crane pushes and pulls all layers concurrently always, and the replaced implementation pushed multiple images at a time. Therefore, no matter what number it will still be less than it was previously.

Related Issue

Fixes #3434
Fixes #3194
Relates to #3113
Relates to #2104

Checklist before merging

Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 4e11e30
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67d0a48bae535f00086b664d

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 50.64103% with 231 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/images/pull.go 55.55% 99 Missing and 13 partials ⚠️
src/internal/packager/images/cache/cache.go 49.35% 31 Missing and 8 partials ⚠️
src/internal/packager/images/push.go 53.16% 26 Missing and 11 partials ⚠️
src/internal/packager/images/common.go 38.46% 20 Missing and 4 partials ⚠️
src/pkg/utils/image.go 0.00% 9 Missing ⚠️
src/internal/packager2/layout/create.go 0.00% 6 Missing ⚠️
src/internal/packager2/layout/sbom.go 33.33% 2 Missing ⚠️
src/pkg/packager/creator/normal.go 0.00% 1 Missing ⚠️
src/pkg/packager/deploy.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/viper.go 53.08% <100.00%> (ø)
src/pkg/cluster/injector.go 66.56% <ø> (ø)
src/pkg/packager/creator/normal.go 7.12% <0.00%> (+0.18%) ⬆️
src/pkg/packager/deploy.go 5.40% <0.00%> (-0.11%) ⬇️
src/internal/packager2/layout/sbom.go 50.60% <33.33%> (+0.20%) ⬆️
src/internal/packager2/layout/create.go 40.66% <0.00%> (+0.15%) ⬆️
src/pkg/utils/image.go 0.00% <0.00%> (ø)
src/internal/packager/images/common.go 22.72% <38.46%> (-13.86%) ⬇️
src/internal/packager/images/push.go 54.73% <53.16%> (+54.73%) ⬆️
src/internal/packager/images/cache/cache.go 49.35% <49.35%> (ø)
... and 1 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RothAndrew
Copy link
Contributor

let's gooooooo! so excited for this lol

git push

Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate off of crane for pulling and pushing OCI images image pull fail from corrupted Crane cache
2 participants