Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During zarf dev find-images automatically add the digest to any tag to help with pinning resources #2247

Open
Racer159 opened this issue Jan 23, 2024 · 3 comments
Assignees
Labels
enhancement ✨ New feature or request

Comments

@Racer159
Copy link
Contributor

Is your feature request related to a problem? Please describe.

As Ezra I want to be able to get the latest digest for a given tag automatically when running zarf dev find-images so that I do not need to manually do this if I want to pin an image to a specific SHA (as zarf dev lint would want me to do)

Describe the solution you'd like

  • Given I have a Zarf package with charts or manifests that need images
  • When I run zarf dev find-images on that package definition
  • Then Zarf will find the image references that it can
  • And Zarf will change any non-SHA-pinned images into a SHA pinned reference when shown to the user.

i.e.

components:
  - name: baseline
    images:
      - defenseunicorns/zarf-game:multi-tile-dark

becomes

components:
  - name: baseline
    images:
      - defenseunicorns/zarf-game:multi-tile-dark@sha256:f78e442f0f3eb3e9459b5ae6b1a8fda62f8dfe818112e7d130a4e8ae72b3cbff

Describe alternatives you've considered

We could do this automatically on create but that may get annoying for people trying to craft a package at a specific version.

Additional context

This should base itself off of the charts and manifests as defined and should not take the existing list of images into account. It should always check the remote registry for the latest manifest SHA at that tag when run. (if the user wishes to hard-pin the image they can edit their values files or manifests to do so)

@waveywaves
Copy link
Contributor

@Racer159 can this be assigned to me ?

@Noxsios
Copy link
Contributor

Noxsios commented Apr 9, 2024

Blocked by #2425

@Noxsios Noxsios added the blocked label Apr 9, 2024
@salaxander salaxander added this to Zarf Jul 22, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zarf Jul 22, 2024
@schristoff schristoff removed the blocked label Nov 8, 2024
@AustinAbro321
Copy link
Contributor

Once the find-images refactor is done per #2969, this would be a good issue to complete

@mkcp mkcp moved this from Backlog to Blocked in Zarf Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
Status: Blocked
Development

Successfully merging a pull request may close this issue.

5 participants