Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful shutdown to clean up canceled deployment #1518

Open
vanakema opened this issue Mar 30, 2023 · 0 comments
Open

Graceful shutdown to clean up canceled deployment #1518

vanakema opened this issue Mar 30, 2023 · 0 comments
Labels
enhancement ✨ New feature or request

Comments

@vanakema
Copy link

Is your feature request related to a problem? Please describe.

I encountered an issue when using Zarf to deploy a failing application. During the deployment, I used Ctrl-C to interrupt the process, but this did not allow Zarf to clean up the state it put in the cluster. As a result, I am forced to wait for the deployment to fail multiple times before Zarf can properly clean up the failed deployment, which can take a significant amount of time (up to 15 minutes per timeout).

Describe the solution you'd like

I propose implementing a graceful shutdown signal when using Ctrl-C during deployment. This will allow Zarf to clean up the cluster state if the deployment is interrupted. Additionally, if Ctrl-C is used during the graceful shutdown, it should trigger a hard stop like it currently does.

Describe alternatives you've considered

An alternative solution would be to provide a separate command to manually trigger a cleanup of a failed deployment in the cluster. This would allow users to clean up the state without waiting for multiple deployment timeouts. The current zarf package delete command fails to clean up a failed deploy due to some secret not existing that it expects.

Additional context

This improvement would save users time and frustration when dealing with failed deployments in Zarf. By implementing a graceful shutdown signal upon using Ctrl-C, users can have more control over their deployment process and avoid waiting for extended periods due to multiple timeouts.

@github-project-automation github-project-automation bot moved this to New Requests in Zarf Project Board Mar 30, 2023
@Racer159 Racer159 added the enhancement ✨ New feature or request label Apr 1, 2023
@Noxsios Noxsios moved this to Backlog in Zarf (old) Mar 7, 2024
@salaxander salaxander added this to Zarf Jul 22, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zarf Jul 22, 2024
@salaxander salaxander removed the status in Zarf Jul 22, 2024
@salaxander salaxander moved this to Triage in Zarf Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
Status: Triage
Development

No branches or pull requests

2 participants