Bluetooth: btusb: Fix memleak in btusb_mtk_submit_wmt_recv_urb

dinghaoliu · holtmann · commit d33fe77bdf75 · 2020-08-31T18:03:08.000+02:00
When kmalloc() on buf fails, urb should be freed just like
when kmalloc() on dr fails.

Signed-off-by: Dinghao Liu &lt;dinghao.liu@zju.edu.cn&gt;
Signed-off-by: Marcel Holtmann &lt;marcel@holtmann.org&gt;
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
@@ -2896,6 +2896,7 @@ static int btusb_mtk_submit_wmt_recv_urb(struct hci_dev *hdev)
 	buf = kmalloc(size, GFP_KERNEL);
 	if (!buf) {
 		kfree(dr);
+		usb_free_urb(urb);
 		return -ENOMEM;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2896,6 +2896,7 @@ static int btusb_mtk_submit_wmt_recv_urb(struct hci_dev *hdev)`
`2896`	`2896`	`buf = kmalloc(size, GFP_KERNEL);`
`2897`	`2897`	`if (!buf) {`
`2898`	`2898`	`kfree(dr);`
	`2899`	`+ usb_free_urb(urb);`
`2899`	`2900`	`return -ENOMEM;`
`2900`	`2901`	`}`
`2901`	`2902`