Skip to content

Commit ac2b081

Browse files
Dan CarpenterWolfram Sang
Dan Carpenter
authored and
Wolfram Sang
committed
i2c: amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling
The problem is that we dereference "privdata->pci_dev" when we print the error messages in amd_mp2_pci_init(): dev_err(ndev_dev(privdata), "Failed to enable MP2 PCI device\n"); ^^^^^^^^^^^^^^^^^ Fixes: 529766e ("i2c: Add drivers for the AMD PCIe MP2 I2C controller") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Wolfram Sang <[email protected]> Cc: [email protected]
1 parent 8839e46 commit ac2b081

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/i2c/busses/i2c-amd-mp2-pci.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -349,12 +349,12 @@ static int amd_mp2_pci_probe(struct pci_dev *pci_dev,
349349
if (!privdata)
350350
return -ENOMEM;
351351

352+
privdata->pci_dev = pci_dev;
352353
rc = amd_mp2_pci_init(privdata, pci_dev);
353354
if (rc)
354355
return rc;
355356

356357
mutex_init(&privdata->c2p_lock);
357-
privdata->pci_dev = pci_dev;
358358

359359
pm_runtime_set_autosuspend_delay(&pci_dev->dev, 1000);
360360
pm_runtime_use_autosuspend(&pci_dev->dev);

0 commit comments

Comments
 (0)