Skip to content

Commit 814b6f9

Browse files
adam900710kdave
authored andcommitted
btrfs: update the comment for submit_extent_page()
Since commit 390ed29 ("btrfs: refactor submit_extent_page() to make bio and its flag tracing easier"), we are using bio_ctrl structure to replace some of arguments of submit_extent_page(). But unfortunately that commit didn't update the comment for submit_extent_page(), thus some arguments are stale like: - bio_ret - mirror_num Those are all contained in bio_ctrl now. - prev_bio_flags We no longer use this flag to determine if we can merge bios. Update the comment for submit_extent_page() to keep it up-to-date. Reviewed-by: Anand Jain <[email protected]> Signed-off-by: Qu Wenruo <[email protected]> Reviewed-by: David Sterba <[email protected]> Signed-off-by: David Sterba <[email protected]>
1 parent d692173 commit 814b6f9

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

fs/btrfs/extent_io.c

+5-3
Original file line numberDiff line numberDiff line change
@@ -1548,11 +1548,13 @@ static int alloc_new_bio(struct btrfs_inode *inode,
15481548
* @size: portion of page that we want to write to
15491549
* @pg_offset: offset of the new bio or to check whether we are adding
15501550
* a contiguous page to the previous one
1551-
* @bio_ret: must be valid pointer, newly allocated bio will be stored there
15521551
* @end_io_func: end_io callback for new bio
1553-
* @mirror_num: desired mirror to read/write
1554-
* @prev_bio_flags: flags of previous bio to see if we can merge the current one
15551552
* @compress_type: compress type for current bio
1553+
*
1554+
* The will either add the page into the existing @bio_ctrl->bio, or allocate a
1555+
* new one in @bio_ctrl->bio.
1556+
* The mirror number for this IO should already be initizlied in
1557+
* @bio_ctrl->mirror_num.
15561558
*/
15571559
static int submit_extent_page(blk_opf_t opf,
15581560
struct writeback_control *wbc,

0 commit comments

Comments
 (0)