Skip to content

Commit 2351f8d

Browse files
dcuirafaeljw
authored andcommitted
PM: hibernate: Freeze kernel threads in software_resume()
Currently the kernel threads are not frozen in software_resume(), so between dpm_suspend_start(PMSG_QUIESCE) and resume_target_kernel(), system_freezable_power_efficient_wq can still try to submit SCSI commands and this can cause a panic since the low level SCSI driver (e.g. hv_storvsc) has quiesced the SCSI adapter and can not accept any SCSI commands: https://lkml.org/lkml/2020/4/10/47 At first I posted a fix (https://lkml.org/lkml/2020/4/21/1318) trying to resolve the issue from hv_storvsc, but with the help of Bart Van Assche, I realized it's better to fix software_resume(), since this looks like a generic issue, not only pertaining to SCSI. Cc: All applicable <[email protected]> Signed-off-by: Dexuan Cui <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 6a8b55e commit 2351f8d

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

kernel/power/hibernate.c

+7
Original file line numberDiff line numberDiff line change
@@ -898,6 +898,13 @@ static int software_resume(void)
898898
error = freeze_processes();
899899
if (error)
900900
goto Close_Finish;
901+
902+
error = freeze_kernel_threads();
903+
if (error) {
904+
thaw_processes();
905+
goto Close_Finish;
906+
}
907+
901908
error = load_image_and_restore();
902909
thaw_processes();
903910
Finish:

0 commit comments

Comments
 (0)