-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where is the Dockerfile of the pgbouncer image? #1964
Comments
We haven't yet open sourced the image. It also includes some patches to pgBouncer. Would like to publish, but other topics had a higher priority so far |
I'm running into a similar situation, where it seems there's some custom config applied to the pgbouncer image that expects these lines in the
When the open source pgbouncer attempts to start with that in the ini file, it will error out. Any insight into what Spilo is doing with pgbouncer to expect that in the ini file would be welcome! |
+1 for publishing Dockerfile of pgBouncer |
+1 for publishing the Dockerfile, or at least be transparent on what are the patches to pgbouncer. We want to know what we are running on our system. |
+1 for publishing the docker image. We want to deploy to ARM64 and this is currently blocking us |
+1 for publishing the Dockerfile and PGBouncer patches, for all the above reasons. It's been about nine months since this issue was opened. |
Hi Guys Any luck on this ? Will really appreciate if you can move it forward. |
+1 for Dockerfile and/or patches. Trying to deploy to a cluster running both arm64 and amd64 nodes, and can't set a nodeSelector for the connectionPooler settings in Postgresql custom resource yaml. |
+1, please upload the dockerfile, needs to update the pgbouncer version and other settings like ssl |
Any update here? |
+1, pgbouncer 1.21 was released with added supprot for prepared statements https://www.pgbouncer.org/2023/10/pgbouncer-1-21-0. The newest version of pgbouncer image is 1.20 and its even unsafe to create own build |
This can be reconstructed through the history
So the missing part is actually the compiled pgbouncer binary. So given that, building an image from the latest pgbouncer image should be fine if it is just about adding things to the config. |
What is the usecase for the robot user? If we put our own pgbouncer image, what would we need to expect to have on it? |
Hey @FxKu, any updates here? we're hoping to leverage this operator in a secure environment but have concerns around CVEs in the image, as well as there being closed-source modifications to pgbouncer. It also looks like there is potentially another zalando-marker application at play as well. Can you publish the source for those? I'm guessing they are light patches to make compatible with the operators settings. or alternatively, publish them as archives somewhere that users could re-use to build their own image? |
agreed. This is a major issue of zalando doing closed-source modifications in what is already an open source product and releases it publicly. |
Found the solution for this, just don't use postgres-operator from zalando (I switched to cloudnative-pg, way better) |
Not long ago I also encountered this problem. I needed to use pgbouncer no lower than version 1.23.0 so that I could use the server_lifetime parameter. I made an image with the latest version 1.24.0. I also disabled the stats_users_prefix parameter without it, everything works fine, I didn’t find any problems, judging by the name of the parameter most likely it relates to some kind of statistics FROM --platform=linux/amd64 registry.opensource.zalan.do/acid/pgbouncer:master-32 as build
USER root
RUN apk update && \
apk add git build-base libtool m4 automake autoconf pandoc-cli pkgconf libevent-dev openssl-dev
RUN git clone https://github.com/pgbouncer/pgbouncer.git
RUN cd pgbouncer && git submodule init && git submodule update && ./autogen.sh && ./configure && make && make install
RUN cp /usr/local/bin/pgbouncer /bin/pgbouncer
FROM --platform=linux/amd64 registry.opensource.zalan.do/acid/pgbouncer:master-32 as image
#RUN pgbouncer --version
USER root
COPY --from=build /usr/local/bin/pgbouncer /bin/pgbouncer
RUN apk add --upgrade apk-tools && \
apk update && apk -U upgrade && \
rm -rf /var/cache/apk/*
USER pgbouncer
RUN sed -i '16s/stats_users_prefix = robot_/#stats_users_prefix = robot_/' /etc/pgbouncer/pgbouncer.ini.tmpl |
I plan to use a docker image to have pgbouncer in a cluster, but for something else than postgres-operator, and I was wondering where is the code of the image so that I can reuse it.
(Seems like the other option is bitnami or "personal" image, I'd prefer to rely on zalando and its beautiful community!)
Thanks :)
The text was updated successfully, but these errors were encountered: