Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add identifier panel in pubchem page #20

Merged
merged 3 commits into from
May 1, 2021

Conversation

kjappelbaum
Copy link
Contributor

@kjappelbaum kjappelbaum commented Apr 29, 2021

with @lpatiny we discussed that it might be useful to show some basic identifiers and a link to Pubchem to give users the possibility
to verify that we retrieved the information for the correct compound.

I noticed that the labels are not optimal atm. I'll fix this upstream in the Pubchem package.

Kevin M. Jablonka added 2 commits April 29, 2021 11:39
with Luc we discussed that it might be useful to show some basic identifiers
and a link to Pubchem to give users the possibility
to verify that we retrieved the information for the correct compound.

i noticed that the labels are not optimal atm.
I'll fix this upstream in the Pubchem package.
@kjappelbaum kjappelbaum marked this pull request as ready for review April 29, 2021 10:39
@kjappelbaum kjappelbaum changed the title identifier feat: identifier pane; Apr 29, 2021
@kjappelbaum kjappelbaum changed the title feat: identifier pane; feat: add identifier panel in pubchem page Apr 29, 2021
@kjappelbaum
Copy link
Contributor Author

i guess this would also close #18

@lpatiny lpatiny merged commit 7c8d0fb into zakodium:master May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants