Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Opus codec anymore (worse audio quality) #1679

Closed
4 tasks done
gechoto opened this issue Oct 26, 2024 · 3 comments · Fixed by #1681
Closed
4 tasks done

No Opus codec anymore (worse audio quality) #1679

gechoto opened this issue Oct 26, 2024 · 3 comments · Fixed by #1681
Labels
bug Something isn't working

Comments

@gechoto
Copy link
Contributor

gechoto commented Oct 26, 2024

Checklist

  • I am able to reproduce the bug with the latest debug version.
  • I've checked that there is no open or closed issue about this bug.
  • This issue contains only one bug.
  • The title of this issue accurately describes the bug.

Steps to reproduce the bug

  1. Play a song with the latest version from dev branch

Expected behavior

It should use Opus formats

Actual behavior

It does not use Opus anymore

Screenshots/Screen recordings

No response

Logs

InnerTune version

dev

Android version

Android 14

Additional information

It happens since the switch to the IOS client here:
dc6bfce

@gechoto
Copy link
Contributor Author

gechoto commented Oct 26, 2024

Somehow ViTune still load Opus. Might be worth looking into what it does different compared to InnerTune.

@gechoto
Copy link
Contributor Author

gechoto commented Oct 26, 2024

Okay I found it. We need to send a recent IOS version as osVersion to get the Opus streams.

@gechoto
Copy link
Contributor Author

gechoto commented Oct 26, 2024

Made a PR adding this: #1681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant