Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix IFD issue breaks overrideAttrs for crate2nix #29

Closed
yusdacra opened this issue Aug 2, 2021 · 0 comments · Fixed by #32
Closed

nix IFD issue breaks overrideAttrs for crate2nix #29

yusdacra opened this issue Aug 2, 2021 · 0 comments · Fixed by #32
Labels
blocked by upstream bug Something isn't working help wanted Extra attention is needed
Milestone
1.1

Comments

@yusdacra
Copy link
Owner

yusdacra commented Aug 2, 2021 •
edited
Loading

crate2nix overrideAttrs does not override the actual package because of a workaround we use for NixOS/nix#4265.
@yusdacra yusdacra added this to the 1.0 milestone Aug 2, 2021
@yusdacra yusdacra added the enhancement New feature or request label Aug 2, 2021
@yusdacra yusdacra changed the title Add the ability to override resulting package derivations with overrideAttrs nix IFD issue blocks breaks overrideAttrs for crate2nix Aug 2, 2021
@yusdacra yusdacra added bug Something isn't working and removed enhancement New feature or request labels Aug 2, 2021
@yusdacra yusdacra changed the title nix IFD issue blocks breaks overrideAttrs for crate2nix nix IFD issue breaks overrideAttrs for crate2nix Aug 2, 2021
@yusdacra yusdacra modified the milestones: 1.0, 1.1 Aug 2, 2021
@yusdacra yusdacra added help wanted Extra attention is needed blocked by upstream labels Aug 2, 2021
@yusdacra yusdacra mentioned this issue Aug 3, 2021
Merged
@yusdacra yusdacra added this to the 1.1 milestone Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked by upstream bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

fix(crate2nix): reimplement overrideAttrs properly yusdacra/nix-cargo-integration
1 participant
@yusdacra