Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] Detect violation of clock error bounds as determined by the NTP clock. #22538

Closed
1 task done
pao214 opened this issue May 24, 2024 · 1 comment
Closed
1 task done
Assignees
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@pao214
Copy link
Contributor

pao214 commented May 24, 2024

Jira Link: DB-11468

Description

Motivation

We wish to use NTP based physical clocks for hybrid timestamps in YugabyteDB (see #21963). NTP based clock error bounds are more precise than the 500ms that we use with the default timestamping mechanism. However, we may run into issues if NTP is not configured correctly. We need a way to detect suboptimal NTP configurations.

Objective

We already do some preliminary checks at startup, but we need a mechanism to verify any issues at runtime for NTP clocks. Here, we rely on much more precise uncertainty windows, and it is best to add additional checks at runtime.

Proposal

Crash when hybrid time exceeds the global limit on receipt of any new message. Protect this under a gflag (and the autoflag for NTP clock) to limit the performance impact of this change.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@pao214 pao214 added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels May 24, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels May 24, 2024
@pao214 pao214 self-assigned this Jun 19, 2024
@pao214 pao214 added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Jun 29, 2024
@pkj415 pkj415 moved this to Pending in Wait-Queue Based Locking Jul 29, 2024
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Aug 21, 2024
@pao214
Copy link
Contributor Author

pao214 commented Sep 4, 2024

Included as part of #21963

@pao214 pao214 closed this as completed Sep 4, 2024
@github-project-automation github-project-automation bot moved this from Pending to Done in Wait-Queue Based Locking Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
Status: Done
Development

No branches or pull requests

2 participants