Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Add yb-sample-apps workload(s) to benchmark restart read requests metric. #22537

Closed
1 task done
pao214 opened this issue May 24, 2024 · 1 comment
Closed
1 task done

[YSQL] Add yb-sample-apps workload(s) to benchmark restart read requests metric. #22537

pao214 opened this issue May 24, 2024 · 1 comment
Assignees
@pao214
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@pao214
Copy link
Contributor

pao214 commented May 24, 2024 •
edited
Loading

Jira Link: DB-11467

Description

Motivation

We test read_after_commit_visibility guarantee in unit tests. However, we need a benchmark to determine the impact of

  1. clock skew
  2. read restart error optimizations

on metrics

  1. restart read metric
  2. latency
  3. read failures

We also wish to demonstrate that we cannot simply reduce max_clock_skew_usec without stale read anomalies.

Cluster Setup

  1. Limit makestep and slewrate.
  2. Stop chrony
  3. timedatectl set-time +100ms
  4. Restart chrony

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@pao214 pao214 added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels May 24, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels May 24, 2024
@pao214 pao214 mentioned this issue May 24, 2024
Closed
1 task
@rthallamko3 rthallamko3 removed the status/awaiting-triage Issue awaiting triage label Jun 3, 2024
@pao214 pao214 mentioned this issue Jun 19, 2024
Open
1 task
@pao214 pao214 added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Jun 29, 2024
@pao214 pao214 changed the title [YSQL] Add yb-sample-apps workload(s) to verify read-after-commit-visibility [YSQL] Add yb-sample-apps workload(s) to benchmark restart read metric. Jul 30, 2024
@pao214 pao214 changed the title [YSQL] Add yb-sample-apps workload(s) to benchmark restart read metric. [YSQL] Add yb-sample-apps workload(s) to benchmark restart read reqeusts metric. Jul 30, 2024
@pao214 pao214 changed the title [YSQL] Add yb-sample-apps workload(s) to benchmark restart read reqeusts metric. [YSQL] Add yb-sample-apps workload(s) to benchmark restart read requests metric. Jul 30, 2024
@pao214
Copy link
Contributor Author

pao214 commented Oct 11, 2024

See SqlStaleReadDetector in yb-sample-apps.

@pao214 pao214 closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pao214 pao214

Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
Wait-Queue Based Locking
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pao214 @rthallamko3 @yugabyte-ci