Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/Digiview] Add extractor #9902

Merged
merged 18 commits into from
Feb 11, 2025
Merged

Conversation

lfavole
Copy link
Contributor

@lfavole lfavole commented May 10, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Added extractor for Digiview URLs (https://ladigitale.dev/digiview).
The extractor forwards the video ID to the YouTube extractor.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added the site-request Request to support a new website label May 10, 2024
Copy link
Contributor Author

@lfavole lfavole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been one year, now you should consider merging my pull request...

Copy link
Collaborator

@seproDev seproDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review capacity is extremely limited. Probably due to needing significant changes, this fell off the radar. Sorry about that. I've left an initial review.

yt_dlp/extractor/digiview.py Outdated Show resolved Hide resolved
yt_dlp/extractor/digiview.py Outdated Show resolved Hide resolved
yt_dlp/extractor/digiview.py Outdated Show resolved Hide resolved
yt_dlp/extractor/digiview.py Outdated Show resolved Hide resolved
yt_dlp/extractor/digiview.py Outdated Show resolved Hide resolved
yt_dlp/extractor/digiview.py Outdated Show resolved Hide resolved
@seproDev seproDev added the pending-fixes PR has had changes requested label Feb 9, 2025
yt_dlp/extractor/digiview.py Outdated Show resolved Hide resolved
yt_dlp/extractor/digiview.py Outdated Show resolved Hide resolved
@lfavole lfavole force-pushed the digiview-extractor branch from 4f243d3 to 4103f65 Compare February 9, 2025 19:06
@lfavole
Copy link
Contributor Author

lfavole commented Feb 11, 2025

Hello, I have updated the PR. Can you take a look at it and maybe merge it?

@seproDev seproDev removed the pending-fixes PR has had changes requested label Feb 11, 2025
@seproDev seproDev changed the title Add Digiview extractor [ie/Digiview] Add extractor Feb 11, 2025
yt_dlp/extractor/digiview.py Outdated Show resolved Hide resolved
yt_dlp/extractor/digiview.py Outdated Show resolved Hide resolved
yt_dlp/extractor/digiview.py Outdated Show resolved Hide resolved
yt_dlp/extractor/digiview.py Outdated Show resolved Hide resolved
@seproDev seproDev merged commit f535530 into yt-dlp:master Feb 11, 2025
5 checks passed
@lfavole lfavole deleted the digiview-extractor branch February 12, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants