-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Warn user when directly launching yt-dlp.exe
#9250
Conversation
Co-Authored-By: Simon Sawicki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good middle ground for giving the user a bit of a hint as to what to do next
This is awesome if the check is reliable. We don't need to error though. Why not launch into interactive mode as-if |
I think people that would double click would kind of be overwhelmed by what
Alternatively, we could also have them enter
We also have to care with what CWD we are at; for example |
I tested this on both Windows 11 and 7 with py2exe, PyInstaller onefile, and PyInstaller onedir builds. In my testing, this worked reliably. |
…9250) Authored by: seproDev, Grub4K Co-authored-by: Simon Sawicki <[email protected]>
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Detect if the user opened the standalone executable by double-clicking, and display a helpful error message.
Co-authored by Grub4K.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?