Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: 1196-contact-info-ui-fix #1203

Closed
wants to merge 3 commits into from
Closed

Draft: 1196-contact-info-ui-fix #1203

wants to merge 3 commits into from

Conversation

PG-Momik
Copy link
Collaborator

@PG-Momik PG-Momik commented May 3, 2023

-[x] fix contact info not showing missing when value is empty string

@PG-Momik PG-Momik requested review from sriza and rajkarnikar11 May 3, 2023 08:18
@what-the-diff
Copy link

what-the-diff bot commented May 3, 2023

PR Summary

  • Updated mix-manifest.json
    The mix-manifest.json file has been updated with the new app.js hash.
  • Improved ContactInfo display
    In the ContactInfo component, we now check for null or empty strings and display 'Missing' instead of an error message when there's no narrative text available.

@PG-Momik PG-Momik requested a review from Sanilblank May 5, 2023 03:55
Sanilblank
Sanilblank reviewed May 5, 2023
View reviewed changes
app/Console/Commands/FixTransaction.php Outdated Show resolved Hide resolved
app/Console/Commands/FixTransaction.php Outdated Show resolved Hide resolved
app/Console/Commands/FixTransaction.php Outdated Show resolved Hide resolved
app/Console/Commands/FixTransaction.php Outdated Show resolved Hide resolved
app/Console/Commands/FixTransaction.php Outdated Show resolved Hide resolved
app/Console/Commands/FixTransaction.php Outdated Show resolved Hide resolved
app/Console/Commands/FixTransaction.php Outdated Show resolved Hide resolved
app/Console/Commands/FixTransaction.php Outdated Show resolved Hide resolved
@PG-Momik PG-Momik force-pushed the 1196-contact-info-ui-fix branch from f74ee6c to db0809f Compare May 5, 2023 10:28
@PG-Momik
-[x] fix showing empty instead of xyz missing
cdb42c0 
-[x] fix recipient country showing false
@PG-Momik PG-Momik force-pushed the 1196-contact-info-ui-fix branch from db0809f to cdb42c0 Compare May 5, 2023 11:39
@PG-Momik PG-Momik self-assigned this May 5, 2023
@PG-Momik PG-Momik changed the title Review: 1196-contact-info-ui-fix Draft: 1196-contact-info-ui-fix May 11, 2023
@sriza sriza added the WTD label Jun 15, 2023
@PG-Momik
Copy link
Collaborator Author

PG-Momik commented Feb 3, 2025

This will not be used.

@PG-Momik PG-Momik closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanilblank Sanilblank Sanilblank left review comments

@sriza sriza Awaiting requested review from sriza

@rajkarnikar11 rajkarnikar11 Awaiting requested review from rajkarnikar11

Assignees

@PG-Momik PG-Momik

Labels
WTD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PG-Momik @Sanilblank @sriza