Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review recipient-country and recipient-region "percentage" labelling #1595

Closed
emmajclegg opened this issue Oct 28, 2024 · 3 comments · Fixed by #1614
Closed

Review recipient-country and recipient-region "percentage" labelling #1595

emmajclegg opened this issue Oct 28, 2024 · 3 comments · Fixed by #1614
Assignees
Labels
Intuitive data entry ODS Issue initiated by ODS

Comments

@emmajclegg
Copy link
Collaborator

emmajclegg commented Oct 28, 2024

For the recipient-country element, the IATI Standard says "When a single recipient country in a vocabulary is declared, the percentage must either be omitted, or set to 100". A similar logic applies to element recipient-region

Currently, if a user populates a single code for either recipient-country or recipient-region in IATI Publisher and leaves percentage unpopulated, the respective element is marked "not completed":

image
image

It is not clear to the user what they need to populate in the data entry form to fix this.


Solution 1: we label the "percentage" field as required (*) for recipient-country and recipient-region, to ensure the user completes it.
Solution 2: we change the data completeness logic to show the elements as "completed" in the situation highlighted above.

I assume solution 1 would be easiest to implement, so would vote for this to avoid overcomplicating the data completeness logic?

NOTE: sector is an element with similar logic, so we would want to ensure consistency.

@emmajclegg emmajclegg added ODS Issue initiated by ODS Support labels Oct 28, 2024
@emmajclegg emmajclegg changed the title Relax recipient-country and recipient-region data completeness alerts Review recipient-country and recipient-region "percentage" labelling Nov 15, 2024
@PG-Momik PG-Momik self-assigned this Nov 18, 2024
@PG-Momik
Copy link
Collaborator

PG-Momik commented Nov 19, 2024

@emmajclegg Thank you for the proposed solutions. As you mentioned, Solution 1 seems the easiest to implement, as it doesn’t require altering the logic for calculating completeness or modifying the existing form validation. It simply involves adding a required * for RR or RC percentage, as well as for Sector percentage.

cc: @Sanam-07 @BibhaT

@PG-Momik PG-Momik assigned Sanam-07 and unassigned PG-Momik Nov 19, 2024
@PG-Momik
Copy link
Collaborator

@emmajclegg This has been deployed to staging. Required * has been added to percentage field in RR, RC and sector.

@PG-Momik PG-Momik assigned emmajclegg and unassigned Sanam-07 Nov 19, 2024
@emmajclegg
Copy link
Collaborator Author

Great - thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Intuitive data entry ODS Issue initiated by ODS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants