Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RHT DeepCopy method to correctly handle nodes with isRemoved set to true #869

Closed
raararaara opened this issue May 21, 2024 · 0 comments
Labels
bug 🐞 Something isn't working sdk ⚒️

Comments

@raararaara
Copy link
Contributor

What happened:
During the DeepCopy operation in RHT (Replicated Hash Table), the set() function is called. However, it has been observed that when isRemoved is set to true, the copied RHTNode always retains a false value for isRemoved. This results in incorrect behavior when dealing with nodes that should have isRemoved set to true.

What you expected to happen:
The DeepCopy method should correctly handle nodes with isRemoved set to true, ensuring that the copied RHTNode maintains the correct value for isRemoved.

How to reproduce it (as minimally and precisely as possible):
The issue can be reproduced by attempting to DeepCopy an RHTNode with isRemoved set to true and observing that the copied node does not retain the isRemoved value during the operation.

Anything else we need to know?:
The DeepCopy method in RHT should be updated to address this issue and ensure that nodes with isRemoved set to true are correctly copied.

Environment:

  • Yorkie version: v0.4.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working sdk ⚒️
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants