Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Devtools UI with Root-only Filter Feature In History #854

Closed
hackerwins opened this issue Jun 27, 2024 · 5 comments · Fixed by #872
Closed

Enhance Devtools UI with Root-only Filter Feature In History #854

hackerwins opened this issue Jun 27, 2024 · 5 comments · Fixed by #872
Assignees
Labels
enhancement 🌟 New feature or request

Comments

@hackerwins
Copy link
Member

hackerwins commented Jun 27, 2024

Description:

Currently, Root of Document stores the content of the document, while Presence stores user presence information such as cursors. During debugging, developers may want to track how the content changes specifically. However, since Presence events can occur more frequently, developers may wish to focus solely on content changes. Introducing a filter feature in History that allows users to view only the root would be beneficial.

Screenshot 2024-06-27 at 4 48 06 PM

Why:

@hackerwins hackerwins added the enhancement 🌟 New feature or request label Jun 27, 2024
@blurfx blurfx moved this to Backlog in Yorkie Project Jul 16, 2024
@gwbaik9717
Copy link
Contributor

Could I give it a try?

@krapie
Copy link
Member

krapie commented Jul 17, 2024

@gwbaik9717 Sure :)

@gwbaik9717
Copy link
Contributor

I considered adding a filter button but wasn't sure where to place it,

so I added an 'expand' button next to the title of the Document tab.

When the user clicks the button, it will expand to occupy the entire space, and clicking it again will revert it to its original state.

However, there is already a fold button (▶) in the History tab, so there might be a possibility that users get confused.

Therefore, I am seeking guidance on this matter.

Also, I noticed that there are SVG icons already in the project. Could you recommend where I should get additional SVG icons from if I want to add more?

Image
Image

@hackerwins hackerwins changed the title Enhance Devtools UI with Root-only Filter Feature Enhance Devtools UI with Root-only Filter Feature In History Jul 18, 2024
@hackerwins
Copy link
Member Author

hackerwins commented Jul 18, 2024

@gwbaik9717 Thanks for your interest in this issue.

I recommend adding Root Filter Button to the right of the four existing navigation buttons on the right side of the History Tab.

Screenshot 2024-07-18 at 10 31 17 AM

I also modified description and title because it seems the original text didn't specifically mention that the filter is for the changes displayed in the History Tab. This lack of clarity might have led to the suggestion of adding it to the Document Tab instead.

@gwbaik9717
Copy link
Contributor

Oh, I got it. thanks for the reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants