-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yorkie.Document initialized twice when entering document editing page #228
Comments
I'm interested in it. Can i try it? |
@wet6123 |
@wet6123 Could you share the progress? |
@devleejb oh I was so busy finishing my school project, so I couldn't work on it. I'll wrap it up by this week! |
@hackerwins I'm trying to reproduce this bug, but I'm unable to reproduce it. Could you please check again, and if the bug is still there, please tell me more about your reproduction. |
In development mode, it runs in StrictMode. So, because of debugging purpose, the Reference: https://sentry.io/answers/react-useeffect-running-twice/Reference: https://sentry.io/answers/react-useeffect-running-twice/ |
What happened:
Under specific circumstances, when entering the document editing page,
yorkie.Document
is initialized twice. Initially, when accessing the document editing page from the document list,yorkie.Client
andyorkie.Document
are initialized once. However, upon returning to the document list and revisiting the document page,yorkie.Document
is initialized twice.screen-capture.webm
This behavior seems to increase the frequency of race condition between
Client.Sync
andClient.Detach
.Related to
document not attached
occurs when Detach and Sync race yorkie-js-sdk#856What you expected to happen:
yorkie.Document
should only be initialized once when entering the document editing page.How to reproduce it (as minimally and precisely as possible):
yorkie.Document
is initialized twice.Anything else we need to know?:
Environment:
The text was updated successfully, but these errors were encountered: