Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: internal/controller #337

Merged
merged 1 commit into from
Sep 19, 2022
Merged

refactor: internal/controller #337

merged 1 commit into from
Sep 19, 2022

Conversation

yottahmd
Copy link
Collaborator

@yottahmd yottahmd commented Sep 19, 2022

Refactor package to make the code cleaner for future maintainability.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Base: 85.21% // Head: 85.16% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (834404c) compared to base (a7b9e6e).
Patch coverage: 84.84% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   85.21%   85.16%   -0.05%     
==========================================
  Files          45       45              
  Lines        3564     3560       -4     
==========================================
- Hits         3037     3032       -5     
- Misses        385      387       +2     
+ Partials      142      141       -1     
Impacted Files Coverage Δ
internal/database/database.go 81.81% <0.00%> (-1.52%) ⬇️
internal/runner/job.go 65.71% <66.66%> (ø)
internal/controller/status_reader.go 79.41% <79.41%> (ø)
internal/controller/controller.go 74.75% <98.11%> (+0.28%) ⬆️
agent.go 79.49% <100.00%> (ø)
cmd/restart.go 61.11% <100.00%> (ø)
cmd/status.go 71.42% <100.00%> (ø)
cmd/stop.go 80.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yottahmd yottahmd merged commit 39fd07e into main Sep 19, 2022
@yottahmd yottahmd deleted the refactor/controller branch September 19, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants