Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overwrite global setting with individual DAG config #201

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

yottahmd
Copy link
Collaborator

Allow users to choose whether or not to send mail on failure with individual DAGs by overriding the MailOn settings.

@codecov-commenter
Copy link

Codecov Report

Merging #201 (44be488) into main (033f467) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   85.08%   85.36%   +0.27%     
==========================================
  Files          46       46              
  Lines        3239     3253      +14     
==========================================
+ Hits         2756     2777      +21     
+ Misses        353      346       -7     
  Partials      130      130              
Impacted Files Coverage Δ
internal/config/config.go 84.47% <100.00%> (+0.16%) ⬆️
internal/config/loader.go 85.51% <100.00%> (+1.07%) ⬆️
internal/reporter/reporter.go 97.43% <100.00%> (ø)
agent.go 80.71% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033f467...44be488. Read the comment docs.

@yottahmd yottahmd merged commit ffd713c into main Jul 20, 2022
@yottahmd yottahmd deleted the feat/overwrite-mailon-config branch July 20, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants