Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier Addon Setting for Nodes settings in color management section #42

Closed
1 task done
MustafaJafar opened this issue Nov 22, 2024 · 0 comments · Fixed by #43
Closed
1 task done

Easier Addon Setting for Nodes settings in color management section #42

MustafaJafar opened this issue Nov 22, 2024 · 0 comments · Fixed by #43
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@MustafaJafar
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues and added correct labels.

Please describe the feature you have in mind and explain what the current shortcomings are?

Nodes settings in color management section expects the admins to know the class of the creator plugins. ayon+settings://nuke/imageio/nodes

IMO, this is hard.

Suggested implementation?

Reuse the names/labels that admins/nuke artists are familiar with.

where the setting shows a drop down menu and select the creators

Publisher Settings suggestion
Image Image
To achieve the result in my screenshot

I've replaced these lines with

def nuke_creator_plugins_enum():
    return [
        {"value": "CreateWritePrerender", "label": "Prerender (write)"},
        {"value": "CreateCamera", "label": "Camera (3d)"},
        {"value": "CreateGizmo", "label": "Gizmo (group)"},
        {"value": "CreateWriteImage", "label": "Image (write)"},
        {"value": "CreateModel", "label": "Model (3d)"},
        {"value": "CreateBackdrop", "label": "Nukenodes (backdrop)"},
        {"value": "CreateWriteRender", "label": "Render (write)"},
        {"value": "CreateSource", "label": "Source (read)"},
    ]

class NodesModel(BaseSettingsModel):
    _layout = "expanded"
    plugins: list[str] = SettingsField(
        default_factory=list,
        title="Used in plugins",
        enum_resolver=nuke_creator_plugins_enum
    )
    nuke_node_class: str = SettingsField(
        title="Nuke Node Class",
    )

Image

Describe alternatives you've considered:

No response

@MustafaJafar MustafaJafar added the type: enhancement Improvement of existing functionality or minor addition label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant