From 4ad17191e65b40a5613deffcb4ada6e5ca287d57 Mon Sep 17 00:00:00 2001
From: Yaliang Wu <ylwu@amazon.com>
Date: Tue, 30 Apr 2024 10:28:56 -0700
Subject: [PATCH] debug

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
---
 .../ml/processor/MLInferenceIngestProcessor.java      |  7 ++++---
 .../org/opensearch/ml/processor/ModelExecutor.java    | 11 -----------
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/plugin/src/main/java/org/opensearch/ml/processor/MLInferenceIngestProcessor.java b/plugin/src/main/java/org/opensearch/ml/processor/MLInferenceIngestProcessor.java
index 0b7a6fe89d..834fdbae6c 100644
--- a/plugin/src/main/java/org/opensearch/ml/processor/MLInferenceIngestProcessor.java
+++ b/plugin/src/main/java/org/opensearch/ml/processor/MLInferenceIngestProcessor.java
@@ -4,6 +4,7 @@
  */
 package org.opensearch.ml.processor;
 
+import static org.opensearch.ml.common.utils.StringUtils.toJson;
 import static org.opensearch.ml.processor.InferenceProcessorAttributes.*;
 
 import java.util.*;
@@ -235,7 +236,7 @@ private void getMappedModelInputFromDocuments(
         String originalFieldPath = getFieldPath(ingestDocument, documentFieldName);
         if (originalFieldPath != null) {
             Object documentFieldValue = ingestDocument.getFieldValue(originalFieldPath, Object.class);
-            String documentFieldValueAsString = toString(documentFieldValue);
+            String documentFieldValueAsString = toJson(documentFieldValue);
             updateModelParameters(modelInputFieldName, documentFieldValueAsString, modelParameters);
         }
         // else when cannot find field path in document, try check for nested array using json path
@@ -248,7 +249,7 @@ private void getMappedModelInputFromDocuments(
                     .parse(sourceObject)
                     .read(documentFieldName);
                 if (!fieldValueList.isEmpty()) {
-                    updateModelParameters(modelInputFieldName, toString(fieldValueList), modelParameters);
+                    updateModelParameters(modelInputFieldName, toJson(fieldValueList), modelParameters);
                 } else if (!ignoreMissing) {
                     throw new IllegalArgumentException("cannot find field name defined from input map: " + documentFieldName);
                 }
@@ -275,7 +276,7 @@ private void updateModelParameters(String modelInputFieldName, String originalFi
             Object existingValue = modelParameters.get(modelInputFieldName);
             List<Object> updatedList = (List<Object>) existingValue;
             updatedList.add(originalFieldValueAsString);
-            modelParameters.put(modelInputFieldName, toString(updatedList));
+            modelParameters.put(modelInputFieldName, toJson(updatedList));
         } else {
             modelParameters.put(modelInputFieldName, originalFieldValueAsString);
         }
diff --git a/plugin/src/main/java/org/opensearch/ml/processor/ModelExecutor.java b/plugin/src/main/java/org/opensearch/ml/processor/ModelExecutor.java
index 03cd4996bf..ed85f2d376 100644
--- a/plugin/src/main/java/org/opensearch/ml/processor/ModelExecutor.java
+++ b/plugin/src/main/java/org/opensearch/ml/processor/ModelExecutor.java
@@ -197,17 +197,6 @@ default Object getModelOutputField(Map<String, ?> modelTensorOutputMap, String f
         }
     }
 
-    /**
-     * Converts the given Object to its JSON string representation using the Gson library.
-     *
-     * @param originalFieldValue the Object to be converted to JSON string
-     * @return the JSON string representation of the input Object
-     */
-
-    default String toString(Object originalFieldValue) {
-        return gson.toJson(originalFieldValue);
-    }
-
     /**
      * Writes a new dot path for a nested object within the given JSON object.
      * This method is useful when dealing with arrays or nested objects in the JSON structure.