Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of y-protocols/auth messages #117

Closed
mifopen opened this issue Aug 31, 2022 — with Huly for GitHub · 1 comment
Closed

Incorrect handling of y-protocols/auth messages #117

mifopen opened this issue Aug 31, 2022 — with Huly for GitHub · 1 comment
Assignees
Labels
bug Something isn't working

Comments

Copy link

mifopen commented Aug 31, 2022

Describe the bug readAuthMessage passes Y.Doc instance to permissionDeniedHandler (or whatever you gave it as the second argument) But permissionDeniedHandler in y-websocket.js thinks it will be a provider https://github.com/yjs/y-websocket/blob/master/src/y-websocket.js#L62

To Reproduce Steps to reproduce the behavior:

  1. Send auth message from server
  2. See Permission denied to access undefined in logs

Expected behavior See Permission denied to access <URL> or smth in logs

Huly®: YJS-528

@mifopen mifopen added the bug Something isn't working label Aug 31, 2022
@dmonad dmonad closed this as completed in 8c04e0a Aug 31, 2022
@dmonad
Copy link
Member

dmonad commented Aug 31, 2022

Thanks, I fixed this. This will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants