Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent twig 3.9 from installing #155

Merged
merged 1 commit into from
Apr 23, 2024
Merged

prevent twig 3.9 from installing #155

merged 1 commit into from
Apr 23, 2024

Conversation

schmunk42
Copy link
Contributor

see also #154 (comment) and following

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #153 (workaround)

Should be removed when lib is updated to work correctly with twig 3.9

@schmunk42
Copy link
Contributor Author

Should be merged and released as 2.4.3.

Compatibility with twig 3.9 should be released as 2.5.0 IMHO.

@schmunk42 schmunk42 mentioned this pull request Apr 23, 2024
@samdark samdark merged commit 0ed174a into master Apr 23, 2024
10 checks passed
@samdark samdark deleted the schmunk42-patch-1 branch April 23, 2024 20:54
@samdark
Copy link
Member

samdark commented Apr 23, 2024

Thanks!

@schmunk42
Copy link
Contributor Author

Could you also create a release 2.4.3?

@schmunk42
Copy link
Contributor Author

@samdark PS: There were no PHP code changes since 2.4.2 2.4.2...master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants