Skip to content
This repository has been archived by the owner on May 18, 2024. It is now read-only.

Supporting Model Subclasses #11

Open
jchang10 opened this issue Apr 19, 2018 · 2 comments · May be fixed by #22
Open

Supporting Model Subclasses #11

jchang10 opened this issue Apr 19, 2018 · 2 comments · May be fixed by #22

Comments

@jchang10
Copy link

I noticed that Model subclasses were not supported. I did a hack in types.py:construct_fields() function to walk the Model's subclasses as well as the Model class itself. It seems to work. It is just a couple lines to modify. Just wanted to note this in case someone else hits this issue.

Thanks for all the work!
Jae

@yfilali
Copy link
Owner

yfilali commented Apr 20, 2018

Would love a pull request if you get a chance, or you can paste the code here with any ideas on a test...

@madama
Copy link

madama commented Aug 23, 2018

@jchang10 would be great if you can share your solution

@jnoortheen jnoortheen linked a pull request Jun 16, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants