-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Fix our peer dependency warnings #418
Comments
This PR will fix both warnings: #4935
these are all gatsby related, many repositories have been archived and we can't do anything about them. but these will no longer be a problem after #4851, I believe we have a reason to leave them alone
I found some PRs about this: These are all the warnings we have, I think we can close this issue, or remove the |
Hi @arcanis can you please assign this to me ? |
NVM, I think @jj811208 already have fixed this in his PR above 👍 |
We have various peer dependency warnings displayed when running
yarn install
inside our own repository. It would be great if we could fix the upstream packages to stop it from happening, as it's a matter of time before it causes more serious issues:Given a warning:
The best fix is generally to either:
Upgrade the faulty package in our codebase to get rid of the warning. Some of those may have already been fixed.
2.0.0-printer-fix.2
error.Mark Y as an optional peer dependency in Z, if Z doesn't need Y to work. If Z's maintainers are concerned about potential warnings being shown to their users, tell them that optional peer dependencies are supported by Yarn, npm 6.1+, and pnpm. It's a feature they should use.
Add Y as a peer dependency of X. This will move the warning up by one level, but by doing this it's possible that the peer dependency will be met in a satisfying way. For example, if
react-bar
as a peer depencency onreact
and is a dependency ofreact-foo
, then you can addreact
to the peer dependencies ofreact-foo
. Then it'll be up to whoever depends onreact-foo
to depends onreact
as well.jest-jasmine2
which should have a peer dependency onjest-haste-map
.Add Y as regular dependency of X if it's just a matter of a peer dependency having been omitted by mistake.
html-react-parser
should probably have regular dependencies on bothobject-assign
andfbjs
to satisfy the requirements ofreact-dom-core
.The text was updated successfully, but these errors were encountered: