Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 3.28: TypeError: this.containerClassNames.join is not a function #377

Closed
danielxdam opened this issue Feb 14, 2022 · 1 comment
Closed

Comments

@danielxdam
Copy link

In Ember 3.28 with ember-modal-dialog 4.0.0 we are getting an error when opening the dialog:

Uncaught (in promise) TypeError: this.containerClassNames.join is not a function basic-dialog.js:37

It looks like basic-dialog.js at line 43 is expecting this.containerClassNames to be an array or null but instead it is a string of the css class names passed in @containerClassNames.

We are extending the ModalDialog class but we haven't made any changes to the @containerClassNames in our subclass. That argument is just being passed on to the parent.

This may be related to or a duplicate of: #374 .

@lukemelia
Copy link
Contributor

I believe this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants