Destroy the text log queue after the I/O blocks. #5854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These blocks contain threads that use the queue, so they must be destroyed first. This was reported by ThreadSanitizer.
alexey-milovidov
changed the title
|
Congratulations, you've done it!
|
alexey-milovidov
approved these changes
Jul 3, 2019
|
The other failure I had locally is caused by libunwind from my distribution. Since we now have libunwind in contrib that doesn't have the problem, I won't fix it. Will merge now. |
stavrolia
pushed a commit
that referenced
this pull request
Jul 5, 2019
These blocks contain threads that use the queue, so they must be destroyed first. This was reported by ThreadSanitizer. (cherry picked from commit 74d1778)
abyss7
pushed a commit
that referenced
this pull request
Jul 11, 2019
These blocks contain threads that use the queue, so they must be destroyed first. This was reported by ThreadSanitizer. (cherry picked from commit 74d1778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These blocks contain threads that use the queue, so they must be
destroyed first. This was reported by ThreadSanitizer.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Fix some ThreadSanitizer failures.