Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make isSupportedAlterType better #5613

Merged
merged 1 commit into from
Jun 14, 2019
Merged

make isSupportedAlterType better #5613

merged 1 commit into from
Jun 14, 2019

Conversation

sundy-li
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Improvement

#5593

It's better to change the list to "unsupported_alter_types",
because unsupported commands are specific and supported are common.

@alexey-milovidov alexey-milovidov merged commit eb1fe2e into ClickHouse:master Jun 14, 2019
@CurtizJ CurtizJ added the pr-improvement Pull request with some product improvements label Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees
No one assigned
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundy-li @alexey-milovidov @CurtizJ