Add system.detached_parts table. #5353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it != Poco::DirectoryIterator(); ++it) | ||
| { | ||
| res.resize(res.size() + 1); | ||
| auto & part = res.back(); |
There was a problem hiding this comment.
BTW, it's pre-C++11 pattern. Now it's better to create an object and move it into vector (if the move is not expensive).
There was a problem hiding this comment.
I'll use emplace_back if you don't mind, not to write push_back in four places.
akuzm
force-pushed
the
aku/detached-parts-5164
branch
from
5fa5507 to
43655a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5164
For changelog. Remove if this is non-significant change.
Added system.detached_parts table containing information about detached parts of MergeTree tables.
Category (leave one):