Functions for calculate lower and high range of an IP address using a CIDR mask #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions in english
|
Would it make sense to return an (IPv4,IPv4) tuple rather than a (UInt32,UInt32) tuple? That would make the interface more intuitive for display/interactive use. Specific use cases can always cast to UInt32 afterwards if needed. |
|
Thanks for the suggestion, now both function return a tuple with an IPv4 and IPv6! |
|
Need to remove |
alexey-milovidov
added a commit
that referenced
this pull request
May 1, 2019
|
IPv6CIDRtoIPv6Range -> IPv6CIDRToRange |
alexey-milovidov
added a commit
that referenced
this pull request
May 1, 2019
| String getName() const override { return name; } | ||
|
|
||
| size_t getNumberOfArguments() const override { return 2; } | ||
| bool isInjective(const Block &) override { return true; } |
|
Missing performance test. |
|
I will fix all the remaining issues. |
alexey-milovidov
added a commit
that referenced
this pull request
May 2, 2019
This was referenced May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Functions for calculate the lower range and an higher range for an IP using a CIDR, both for
IPv4andIPv6.Detailed description (optional):
This two functions, named
IPv4CIDRtoIPv4RangeandIPv6CIDRtoIPv6Rangetake two arguments, an IP address (inIPv4address for theIPv4function, and inIPv6addressfor
IPv6function), and anUInt8who correspond to the CIDR mask we want to apply.An equivalent of
IPv4CIDRtoIPv4Range(IPv4NumToString('192.168.0.0'), 16)can be interpreted as192.168.0.0/16using the CIDR notation.It return a tuple containing two
IPv4for theIPv4functions and a tuple containing twoIPv6for theIPv6, it contain for both the theorically the lowest and highest IP for the subnet.This function can potentially use to know if an IP is part of a subnet, and also if we use the lowest or highest range to aggregate the IP by subnet.
A possible solution was posted on issue #247 for an
IPv4range (solution based also on the first post of the issue) using directly a query and using a bit shifting. But it wouldn't be possible for calculate anIPv6subnet as Clickhouse storedIPv6using aFixedString(16), who make the task a little bit difficult with doing a bit shifting on an array.